Recovery phrase unverified status based on last_authentication.
#3519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recovery-phrase' into sea-snake/persistent-unverified-recovery-phrase
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the recovery phrase verification system to support two verification methods: selecting words from a shuffled list (when the phrase is in memory) and typing the entire phrase (when signing in again after sign-out). The key change is using last_authentication field to determine if a recovery phrase has been verified (null = unverified).
- Renamed
Verifycomponent toVerifySelectingand created newVerifyTypingcomponent for manual phrase entry - Implemented reusable
RecoveryPhraseInputcomponent with accessibility features and validation - Updated verification logic to call the canister with the recovery phrase identity to mark it as used
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/frontend/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/recovery/+page.svelte |
Updates unverified status detection to use last_authentication field; implements handleVerify to authenticate with recovery phrase and mark as used |
src/frontend/src/lib/components/wizards/createRecoveryPhrase/views/VerifyTyping.svelte |
New component for manual recovery phrase entry with auto-submit and validation |
src/frontend/src/lib/components/wizards/createRecoveryPhrase/views/VerifySelecting.svelte |
Minor text formatting change adding colon to instruction |
src/frontend/src/lib/components/wizards/createRecoveryPhrase/views/Retry.svelte |
Adds verification method prop to show different error messages for selecting vs typing |
src/frontend/src/lib/components/wizards/createRecoveryPhrase/CreateRecoveryPhraseWizard.svelte |
Adds action prop and error handling; routes between VerifySelecting and VerifyTyping based on phrase availability |
src/frontend/src/lib/components/views/RecoveryPhraseInput.svelte |
New reusable component for entering 24-word recovery phrase with paste support, keyboard navigation, and validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/recovery/+page.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/createRecoveryPhrase/CreateRecoveryPhraseWizard.svelte
Show resolved
Hide resolved
src/frontend/src/lib/components/views/RecoveryPhraseInput.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/views/RecoveryPhraseInput.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/views/RecoveryPhraseInput.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/views/RecoveryPhraseInput.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/createRecoveryPhrase/views/VerifyTyping.svelte
Outdated
Show resolved
Hide resolved
aterga
reviewed
Nov 28, 2025
.../src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/recovery/+page.svelte
Outdated
Show resolved
Hide resolved
aterga
reviewed
Nov 28, 2025
.../src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/recovery/+page.svelte
Show resolved
Hide resolved
…access-and-recovery)/recovery/+page.svelte Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
aterga
reviewed
Nov 28, 2025
.../src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/recovery/+page.svelte
Outdated
Show resolved
Hide resolved
aterga
reviewed
Nov 28, 2025
aterga
reviewed
Nov 28, 2025
src/frontend/src/lib/components/views/RecoveryPhraseInput.svelte
Outdated
Show resolved
Hide resolved
aterga
reviewed
Nov 28, 2025
aterga
reviewed
Nov 28, 2025
src/frontend/src/lib/components/views/RecoveryPhraseInput.svelte
Outdated
Show resolved
Hide resolved
aterga
approved these changes
Nov 28, 2025
Contributor
aterga
left a comment
aterga
left a comment
There was a problem hiding this comment.
Approving modulo tests (feel free to add them in a follow up PR, since this feature is disabled)
sea-snake
deleted the
sea-snake/persistent-unverified-recovery-phrase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recovery phrase unverified status based on
last_authentication.Changes
Verifycomponent toVerifySelecting.RecoveryPhraseInputcomponent.VerifyTyping.RecoveryPhraseWizardto use eitherVerifySelectingorVerifyTypingdepending on the availability of the valid recovery phrase in memory (e.g. user signed out and in -> not available)./manage/recoverypage to uselast_authenticationto decide if a recovery phrase is unverified (null = not used yet).Tests
No tests have been updated in this PR, existing e2e tests should pass in the CI/CD pipeline.
Notes
RecoveryPhraseInputcomponent will be used on theuse recovery phrase screenin a later PR.VerifyTypingwill be added in a later PR.